Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using I18n save text #17415

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

Eric-Guo
Copy link
Contributor

@Eric-Guo Eric-Guo commented Dec 10, 2024

What are you trying to accomplish?

Add missing I18n in the button.

Screenshots

Before

image

After

image

What approach did you choose and why?

I don't see other approach available here.

Merge checklist

  • Tested major browsers (Chrome, Firefox, Edge, ...)

@Eric-Guo Eric-Guo force-pushed the activity_comment_save_text branch 4 times, most recently from 1ef29a9 to f6a2345 Compare December 12, 2024 04:04
@Eric-Guo Eric-Guo force-pushed the activity_comment_save_text branch from f6a2345 to ed46c6d Compare December 12, 2024 11:59
Copy link
Member

@oliverguenther oliverguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍

@oliverguenther oliverguenther merged commit 8e9be01 into opf:dev Dec 12, 2024
10 checks passed
@Eric-Guo Eric-Guo deleted the activity_comment_save_text branch December 13, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants